feat(selector): allow multiple change sources with ChangeDescriptor #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nymius
force-pushed
the
feat/add-ChangeDescriptor-enum
branch
2 times, most recently
from
c589508 to
bcb018f
Compare
Previously, the `change_descriptor` field only accepted a definite descriptor to derive the change output script pubkey. This worked for most cases but failed for scenarios - such as silent payments - where a definite descriptor is not available. Now `change_descriptor` is `change_script` and can take a ScriptSource, which can be a descriptor or the script itself. Also, `change_weights` field is added as a field of SelectorParams, to externalize the calculus of the satisfaction weight from the API. This allowed the remove of the `to_cs_change_weigths` method. `From<(ScriptSource, Amount)>` for Output is added for conveniency.
nymius
force-pushed
the
feat/add-ChangeDescriptor-enum
branch
from
bcb018f to
aadeca5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the
change_descriptorfield only accepted a definite descriptor to derive the change output script pubkey. This worked for most cases but failed for scenarios - such as silent payments - where a definite descriptor is not yet available.To address this, introduce the
ChangeDescriptorenum, which supports:This makes change output generation flexible enough to handle both standard and exceptional workflows.
Fixes #17
All Submissions:
cargo +nigthly fmtbefore committingNew Features: